fix: nested transformer request scope leakage#10281
Merged
michalsn merged 2 commits intoJun 7, 2026
Merged
Conversation
michalsn
added
the
bug
datamweb
approved these changes
Jun 6, 2026
datamweb
left a comment
datamweb
left a comment
Contributor
There was a problem hiding this comment.
This looks like an elegant bug fix with excellent foresight. Thanks!
| throw ApiException::forMissingInclude($include); | ||
| self::$depth++; | ||
|
|
||
| try { |
Contributor
There was a problem hiding this comment.
I really liked the use of try block!
patel-vansh
approved these changes
Jun 6, 2026
paulbalandan
approved these changes
Jun 6, 2026
Member
Author
|
Thanks everyone for the review! |
gr8man
pushed a commit
to gr8man/CodeIgniter4
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where nested transformers created inside
include*()methods could inherit the root request'sfieldsandincludequery parameters.Bare nested transformers now skip the root request scope, while root transformers and explicitly passed requests keep their existing behavior.
Ref: #10278
Checklist: